Open
Conversation
bkeryan
reviewed
Sep 24, 2025
There was a problem hiding this comment.
I think you will need to specify a deployment environment in order to publish to non-test PyPI.
https://dev.azure.com/ni/DevCentral/_wiki/wikis/AppCentral.wiki/138308/How-to-Publish-to-PyPI-From-GitHub (internal link) has instructions on how to set this up.
bkeryan
reviewed
Sep 24, 2025
There was a problem hiding this comment.
FYI, some security recommendations:
- Pin actions to specific commit hashes (or at least release tags), not branches like master.
- Pin/lock Python packages to specific versions.
- Split build and publish into separate jobs, using upload-artifact to pass dist/* between them.
- In Settings >> Actions >> General, set Workflow Permissions to Read repository contents and packages permissions, and only grant
permissions: id-token: writeto the publish job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Set up trusted publishing.
Why should this Pull Request be merged?
Removes the need to manage secrets to publish packages to pypi.org.
What testing has been done?
none